[PATCH 1/1] ubi: Introduce block devices for UBI volumes

Ezequiel Garcia ezequiel.garcia at free-electrons.com
Mon Feb 10 03:12:00 EST 2014


On Mon, Feb 10, 2014 at 08:53:14AM +0100, Richard Weinberger wrote:
> Am 10.02.2014 02:29, schrieb Ezequiel Garcia:
> >>> +
> >>> +               mutex_lock(&dev->vol_mutex);
> >>> +               res = do_ubiblock_request(dev, req);
> >>> +               mutex_unlock(&dev->vol_mutex);
> >>
> >> This means that you can never do parallel IO?
> >>
> > 
> > Indeed. Feel free to prepare a follow-up patch improving it,
> > once this is merged.
> 
> Sorry, this is a very lame argument.
> 
> You need to describe why your application design has this flaw.

Not at all. It's perfectly fine to merge a feature with a simple
implementation and improve it progressively. In fact, I've explicitly
chosen the simplest implementation whenever possible. We can always
get back here and improve the performance.
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com



More information about the linux-mtd mailing list