[PATCH 1/1][v3] IFC: Change IO accessor based on endianness

[Scott Wood]

On Mon, 2014-12-01 at 16:45 +0530, Jaiprakash Singh wrote:
> @@ -377,31 +377,31 @@ static void fsl_ifc_do_read(struct nand_chip *chip,
>  
>  	/* Program FIR/IFC_NAND_FCR0 for Small/Large page */
>  	if (mtd->writesize > 512) {
> -		iowrite32be((IFC_FIR_OP_CW0 << IFC_NAND_FIR0_OP0_SHIFT) |
> +		ifc_out32((IFC_FIR_OP_CW0 << IFC_NAND_FIR0_OP0_SHIFT) |
>  			    (IFC_FIR_OP_CA0 << IFC_NAND_FIR0_OP1_SHIFT) |
>  			    (IFC_FIR_OP_RA0 << IFC_NAND_FIR0_OP2_SHIFT) |
>  			    (IFC_FIR_OP_CMD1 << IFC_NAND_FIR0_OP3_SHIFT) |
>  			    (IFC_FIR_OP_RBCD << IFC_NAND_FIR0_OP4_SHIFT),
>  			    &ifc->ifc_nand.nand_fir0);

You're still breaking continuation line alignment, here and elsewhere...

> +		addr = ifc_nand_ctrl->addr;
>  		if (chip->options & NAND_BUSWIDTH_16)
> -			setbits16(ifc_nand_ctrl->addr, NAND_STATUS_WP);
> +			ifc_out16((ifc_in16(addr) | (NAND_STATUS_WP)), addr);
>  		else
> -			setbits8(ifc_nand_ctrl->addr, NAND_STATUS_WP);
> +			ifc_out8((ifc_in8(addr) | (NAND_STATUS_WP)), addr);
>  		return;

Unnecessary parentheses

-Scott