[PATCH] mtd: spi-nor: fix the wrong dummy value

Huang Shijie b32955 at freescale.com
Wed Apr 16 22:01:25 PDT 2014


On Thu, Apr 17, 2014 at 01:40:29AM +0200, Marek Vasut wrote:
> On Wednesday, April 16, 2014 at 10:18:19 AM, Huang Shijie wrote:
> > The dummy cycles is actually 8 for SPI fast/dual/quad read.
> > 
> > This patch fixes the wrong dummy value for both the spi-nor.c and m25p80.c.
> > 
> > Signed-off-by: Huang Shijie <b32955 at freescale.com>
> 
> Inspecting this patch, I see the code will behave identically with/without this 
> patch. It is thus unclear to me from the commit message, why this change is 
> necessary.
> 
firstly, in theory, the dummy cycles should be 8, not 1.
secondly, the DDR QUAD READ may use 4 dummy cycles.

thanks
Huang Shijie





More information about the linux-mtd mailing list