[PATCH 2/2] mtd-utils: integck: add support for volume specific power-cut test

Artem Bityutskiy dedekind1 at gmail.com
Tue Apr 15 06:12:12 PDT 2014


Hi Mats,

pushed the first patch out, thanks.

On Mon, 2014-04-14 at 11:47 +0000, Mats Kärrman wrote:
> -"continues forever.\n";
> +"continues forever.\n"
> +"Whereas -p requires power cut emulation to be enabled globally, the -P option\n"
> +"automatically enables the use of power cut emulation on the tested fs instance\n"
> +"only (currently implemented for UBIFS only).\n";

Could we please invent an easy to understand way of naming this and the
option.

So essentially, this is about emulating power cuts at UBI and UBIFS
levels. The "reenabling" thing is a small details which should not be
visible in --help, because it is confusing anyway.

I'd suggest to split this patch on 2. First patch renames the option to
'--ubi-power-cut', refines help message, may be some comments and
function names, if needed.

The second patch introduces '--ubifs-power-cut', and explains that this
makes sure that power cuts happen in the UBIFS driver, versus the
underlying UBI driver.

Thanks!

-- 
Best Regards,
Artem Bityutskiy




More information about the linux-mtd mailing list