[PATCH v4 5/5] mtd: nand: Improve bitflip detection for on-die ECC scheme.

[David Mosberger-Tang]

Brian,

On Tue, Apr 1, 2014 at 12:01 PM, Brian Norris
<computersforpeace at gmail.com> wrote:

> The point is that we don't write code into the generic framework that
> assumes Micron is the only one to implement it, if possible. This type
> of replaceable feature is best left as a callback which can be set to
> NULL, I think. Or if you can find a better point at which the
> implementation specifics can be abstracted, that can work as well. But
> regardless, my high level comment must be addressed -- you wrote this
> code as if Micron is the only one to implement on-die ECC.
>
> FWIW, the Toshiba BENAND (Built-in ECC NAND) datasheet I saw doesn't
> advertise the ability to disable its ECC, but it does report per-sector
> bitflip information (nice!). Also, I think it hides the ECC syndrome
> bytes from the user, so most drivers could possibly ignore the built-in
> ECC entirely if desired.

I can only make the patch as good as I know how to.
If you need a perfect patch before doing *anything*, chances are
the situation won't improve at all.

I really don't understand when Linux kernel development stopped
accepting improvements just because they're not perfect.  Incremental
improvements are part and parcel of Linux development, at least that's
what I always thought.

The patch as it stands is safe and it improves on the status quo.
If that's not good enough, fine, I tried to do my part.

Really, there is no direct benefit for me to spend time getting this merged.
I'm doing it because I thought it's the right thing to do to contribute back
a little bit since my company by relying on Linux is really is standing on
the shoulders of giants.

I'm sorry if I have sent too many patch revisions in too short amount
of time.  I tried to incorporate feedback and avoid duplicate comments
by providing updated patches.  Also, I don't have much time available,
so the longer this process takes, the less likely I'll be able to finish it
(please don't take that as a threat, it's really just my reality).

  --david