[PATCH v4 4/5] mtd: nand: Allocate extra buffers needed for on-die ECC controller.

Gupta, Pekon pekon at ti.com
Tue Apr 1 00:37:46 PDT 2014


Hi Brian,

>From: Brian Norris [mailto:computersforpeace at gmail.com]
>>On Mon, Mar 31, 2014 at 05:28:56PM -0600, David Mosberger wrote:
[...]
>> diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
>> index dbb99b3..456809b 100644
>> --- a/include/linux/mtd/nand.h
>> +++ b/include/linux/mtd/nand.h
>> @@ -533,6 +533,8 @@ struct nand_buffers {
>>  	uint8_t	*ecccalc;
>>  	uint8_t	*ecccode;
>>  	uint8_t *databuf;
>> +	uint8_t *chkbuf;
>> +	uint8_t *rawbuf;
>
>Do you really need two additional buffers? Can you get by with just one
>of them?
>

Some similar comments have been provided in the previous versions
of the patch. But due to in-consistency in $subject, they might not
be visible as a thread of same discussion.
You may like to review and comment on below threads also.


[PATCH] mtd: nand: Add support for Micron on-die ECC controller (rev2).
http://lists.infradead.org/pipermail/linux-mtd/2014-March/052949.html

[RFC] mtd: nand: Preparatory patch for adding on-die ECC controller support ...
http://lists.infradead.org/pipermail/linux-mtd/2014-March/052969.html


with regards, pekon



More information about the linux-mtd mailing list