[PATCH v4 05/12] mtd: nand: print out the cell information for nand chip

Brian Norris computersforpeace at gmail.com
Mon Sep 30 18:49:42 EDT 2013


On Wed, Sep 25, 2013 at 02:58:14PM +0800, Huang Shijie wrote:
> Print out the cell information for nand chip.
> 
> (Since the message is too long, this patch also splits the log
> with two separate pr_info())
> 
> Signed-off-by: Huang Shijie <b32955 at freescale.com>
> ---
>  drivers/mtd/nand/nand_base.c |   11 +++++++----
>  1 files changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index 94d9084..b94309b 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -3460,11 +3460,14 @@ ident_done:
>  	if (mtd->writesize > 512 && chip->cmdfunc == nand_command)
>  		chip->cmdfunc = nand_command_lp;
>  
> -	pr_info("NAND device: Manufacturer ID: 0x%02x, Chip ID: 0x%02x (%s %s),"
> -		" %dMiB, page size: %d, OOB size: %d\n",
> +	pr_info("NAND device: Manufacturer ID: 0x%02x,"
> +			"Chip ID: 0x%02x (%s %s) \n",

You're adding excess whitespace before the '\n'. I'll squash this
myself.

>  		*maf_id, *dev_id, nand_manuf_ids[maf_idx].name,
> -		chip->onfi_version ? chip->onfi_params.model : type->name,
> -		(int)(chip->chipsize >> 20), mtd->writesize, mtd->oobsize);
> +		chip->onfi_version ? chip->onfi_params.model : type->name);
> +
> +	pr_info("NAND device: %dMiB, %s, page size: %d, OOB size: %d\n",
> +		(int)(chip->chipsize >> 20), nand_is_slc(chip) ? "SLC" : "MLC",
> +		mtd->writesize, mtd->oobsize);
>  
>  	return type;
>  }

Brian



More information about the linux-mtd mailing list