[PATCH v3 06/10] mtd: fix the wrong mtd->type for nand chip

[Brian Norris]

Hi Huang,

Sorry, I overlooked responding to this one.

On Thu, Sep 05, 2013 at 12:03:04PM +0800, Huang Shijie wrote:
> 于 2013年09月05日 02:51, Brian Norris 写道:
> 
>     You could precede this patch with one that prevents exporting
>     MTD_MLCNANDFLASH in mtd_type_show() and in ioctl(MEMGETINFO). I'm not
>     saying you *must* do this, but that this side effect must be
>     acknowledged and explained better, or else it seems that you don't
>     understand the ramifications of your proposed changes.
> 
> [1] If you think we should not _change_ any code of the application, such as
> the mtd-utils,

That's the true meaning of "we don't break ABI compatibility". mtd-utils
that work today on a given board with a given set of hardware (e.g., MLC
NAND flash) should not need modified to handle the same features on a
newer kernel.

However, I think it is safe to say that the MLC vs. SLC distinction
isn't made clear in mtd-abi.h (i.e., we already have MTD_MLCNANDFLASH),
and that this change is justified.

>     I can create a patch to prevents exporting the MTD_MLCNANDFLASH in
> mtd_type_show() and
>     in ioctrl(MEMGETINFO).

I don't think this is actually necessary. It is desirable that users can
see the difference between SLC and MLC, but this should be explained.

> [2] else, I prefer to explain better for this patch.

Yes, please explain it better (and reorder some patches, as I explained
previously) in order to

(1) show that you understand completely what your patches are doing and

(2) more clearly notify other developers of the modified ABI

Thanks,
Brian