[PATCH 04/25] mtd: nand: gpmi-nand: janitorial cleanup: (commas after last element of struct initializer)

Lothar Waßmann LW at KARO-electronics.de
Mon Sep 2 02:14:27 EDT 2013


Hi,

David Woodhouse writes:
> On Thu, 2013-08-01 at 07:50 +0200, Lothar Waßmann wrote:
> > Huang Shijie writes:
> > > is it any bad influence if we do not apply this patch?
> > > 
> > > I am not clear what we can benefit from this patch.
> > > 
> > less eye sore when looking at the code and eventual copies of it in
> > other places.
> 
> But it's actually a *good* practice to have the redundant commas at the
> end of the line, in the general case.
> 
> It does absolutely no harm, and makes the final line appear *consistent*
> with the other lines. I don't see why it would make your eye sore on the
> final line when it's there and necessary on the previous lines.
> 
My patch _added_ the commas and _made_ the last lines consistent with
the other ones...


Lothar Waßmann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________



More information about the linux-mtd mailing list