[Rebase/PATCHv2] drivers: mtd: m25p80: Add quad read support.

[Brian Norris]

On Thu, Oct 31, 2013 at 10:31:23AM +0530, Sourav Poddar wrote:
> On Thursday 31 October 2013 04:49 AM, Brian Norris wrote:
> >On Wed, Oct 30, 2013 at 02:50:02PM +0530, Sourav Poddar wrote:
> >>@@ -95,6 +102,7 @@ struct m25p {
> >>  	u8			program_opcode;
> >>  	u8			*command;
> >>  	bool			fast_read;
> >>+	bool                    quad_read;
> >Did you have a response to my earlier suggestion that the fast_read and
> >quad_read fields be combined to a single field? This could easily be an
> >enum, and I think it could help some of the other code. It also wouldn't
> >require us to remember that quad_read takes precedence over fast_read
> >(which you do implicitly in this patch). And we can already foresee
> >additional switches needed if we add the DDR command types (Huang was
> >looking at this?), so we should just get it right now.
> >
> >You could, perhaps, make this two patches: one for converting the bool
> >to an enum, and the other for supporting quad-read.
> >
> I read that, and I was planning to take that as a seperate
> excercise, but yes I
> will cook this into two independent patches.

I think it is good to require the correct design principle (and
appropriate cleanup) before adding new features.

Brian