Patching mkfs.ubifs.c for running under Windows ?

[Richard Weinberger]

On Mon, Oct 28, 2013 at 2:38 AM, Florian Fainelli <florian at openwrt.org> wrote:
> Hello,
>
> 2013/10/26 Artem Bityutskiy <dedekind1 at gmail.com>:
>> On Sat, 2013-09-21 at 12:58 +0200, gutemine wrote:
>>> As users of ubidump under Windows now asked me for getting also the
>>> possibility to re-pack their extracted ubifs images, I'm considering to
>>> patch mkfs.ubifs.c, so that it handles also the Windows hard and softlinks
>>> and my dummy device files correctly.
>>
>> Generally, I am OK with making the code support windows, why not? But
>> this should be done very nicely and should not be intrusive. I guess you
>> should send patches and then we'll see.
>
> We do have some patches in OpenWrt to make mtd-utils build and work
> under FreeBSD and Cygwin here:
>
> https://dev.openwrt.org/browser/trunk/tools/mtd-utils/patches
>
> in particular:
> https://dev.openwrt.org/browser/trunk/tools/mtd-utils/patches/110-portability.patch
> https://dev.openwrt.org/browser/trunk/tools/mtd-utils/patches/120-cygwin_fixes.patch
> https://dev.openwrt.org/browser/trunk/tools/mtd-utils/patches/134-freebsd_loff_t.patch
>
> Not sure how acceptable they look like to you?

Looks not that bad. :-)
But why do you need the file "include/cygwin/bits-byteswap.h"?

Artem, what do you think?
IMHO adding cygwin support is less intrusive than adding native win32 support.

-- 
Thanks,
//richard