[PATCH V2] mtd: gpmi: fix the ecc regression
computersforpeace at gmail.com
Fri Oct 25 10:08:06 PDT 2013
On Fri, Oct 25, 2013 at 7:08 AM, David Woodhouse <dwmw2 at infradead.org> wrote:
> On Fri, 2013-10-25 at 21:41 -0400, Huang Shijie wrote:
>> On Fri, Oct 25, 2013 at 02:29:42PM +0100, David Woodhouse wrote:
>> > On Fri, 2013-10-25 at 21:33 -0400, Huang Shijie wrote:
>> > >
>> > > I am ok with your patch. but we will meet a compiler warning, since
>> > > the set_geometry_by_ecc_info() is not referenced.
>> > Yeah, I predicted that but at this stage with *hours* to catch Linux and
>> > get it into 3.12, I think that's the better option. I'll note it in the
>> > commit comment.
>> ok. Please add my ack for your formal patch:
>> Acked-by: Huang Shijie <shijie8 at gmail.com>
> I've just pushed this to the tip of the tree, replacing the version that
> Brian had put there.
A tiny comment on the description. You say:
"The "legacy" ECC layout used until 3.11 uses all the OOB area by
computing the ECC strength and ECC step size ourselves."
This phrase "until 3.11" sounds like the layout changed in 3.11 (which
it did not). The rest of the commit message might clear that up, but
> Brian, are you still happy to send the pull request to Linus or do you
> want me to?
I'm happy either way, as long as the fixes go in. I'll send it, since
I still have the day ahead of me in my timezone.
More information about the linux-mtd