[PATCH V2 0/4] mtd: gpmi: support two nand chips at most

Brian Norris computersforpeace at gmail.com
Wed Oct 23 15:37:55 PDT 2013


On Mon, Oct 21, 2013 at 11:40:16AM +0800, Huang Shijie wrote:
> 于 2013年10月19日 10:01, Brian Norris 写道:
> > Yes, I seem to have overlooked this set. I think it must have come in
> > parallel with your MLC patch set, so I delayed it until the MLC patch
> > set settled down?
> >
> this patch set has no relationship with MLC patch.

Well, it did touch the same driver, and your patch set kept evolving so
I chose to focus on just one of your patch sets at a time there...

I'll take a look now.

> > Anyway, I'll revisit this soon. But I probably need to take care of
> > your mtd-utils updates first, since they should go along with the MLC
> > patch set.
> >
> > And on top of that (to update the world on daily status), I seem to be
> > tripping over some UBIFS bugs that are inhibiting the validation I'm
> > trying to do for some new hardware. So, I'm all-around pretty busy!
> > I'll get myself together next week, hopefully.
> understood.
> 
> 
> I am too busy too, i am starting to code the Qspi driver now.
> I was blocked by a bluetooth/uart/dma issue last month.
> > In the meantime, other people's code could use some extra eyes. I know
> > Ezequiel just sent out a 27 (!) patch series today. There's also the
> > pending cmdline.c patch from months ago, where Cai Zhiyong wanted to
> > migrate our command line partition parser to a common
> > block/cmdline-parser.c. Part of her work (for block devices) is
> I like Cai zhiyong's patch. But I do not have time to test his patch.

Well, this represents a bad community mentality, where people have time
to submit plenty of code for their own drivers, and ask a lot from
maintainers to review and merge their code, yet they do not have any
time to review others' work. I believe that bearing the sole
responsibility of code review is a major contributing factor in both
Artem's and my long latency to merging patches.

That said, I understand that people get very busy sometimes, and I don't
mean to particularly focus on you, Huang. This is a general pattern that
I've seen, and I have done the same thing previously, where I simply did
not have (and did not make) time to review others' work much.

Brian



More information about the linux-mtd mailing list