[PATCH] mtd: nand: pxa3xx: Fix registered MTD name

Ezequiel Garcia ezequiel.garcia at free-electrons.com
Fri Oct 18 02:33:17 PDT 2013


On Thu, Oct 17, 2013 at 06:36:18PM -0700, Brian Norris wrote:
> On Thu, Oct 17, 2013 at 06:24:57AM -0300, Ezequiel Garcia wrote:
> > In a recent commit:
> > 
> >   commit f455578dd961087a5cf94730d9f6489bb1d355f0
> >   Author: Ezequiel Garcia <ezequiel.garcia at free-electrons.com>
> >   Date:   Mon Aug 12 14:14:53 2013 -0300
> > 
> >   mtd: nand: pxa3xx: Remove hardcoded mtd name
> > 
> >   There's no advantage in using a hardcoded name for the mtd device.
> >   Instead use the provided by the platform_device.
> > 
> > The MTD name was changed to use the one provided by the platform_device.
> > However, this can be problematic as some users want to set partitions
> > using the kernel parameter 'mtdpart', where the name is needed.
> > 
> > For that reason, using a simpler and easier to remember name such
> > as 'pxa3xx-nand' is certainly a better choice.
> 
> Hmm, if we're really interested in the user experience of 'mtdparts'
> users, shouldn't we just revert to the old name ("pxa3xx_nand-0") to
> avoid breaking systems? Or are there no users that would care?
> 

Dammit! yes, that's the intention of this patch: revert to the old name
"pxa3xx_nand-0" to avoid breaking systems.

Guess I couldn't manage my OCD and picked a more appealing name :)

I'll send a v2 right away.
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com



More information about the linux-mtd mailing list