[PATCH] [RESEND] mtd: docg4: fix status polling loop

Mike Dunn mikedunn at newsguy.com
Fri Oct 11 11:31:18 PDT 2013


On 10/11/2013 11:16 AM, Brian Norris wrote:
> Hi Mike,
> 
> On Thu, Oct 10, 2013 at 10:25:27AM -0700, Mike Dunn wrote:
>> The loop that polls the status register waiting for an operation to complete
>> foolishly bases the timeout simply on the number of loop iterations that have
>> ocurred.  When I increased the processor clock speed, timeouts started to appear
>> for long block erasure operations.  This patch measures the timeout using
>> jiffies.
>>
>> Signed-off-by: Mike Dunn <mikedunn at newsguy.com>
>> ---
>>
>> This is a rework of an earlier patch, based on Artem's recommendation to use
>> jiffies, not udelay() (thanks Artem).  I didn't mark it 'v2' because the rework
>> makes the original name of the patch inaccurate, so now it has a different name.
>>
>> This was originally sent a couple months ago... was probably a bad time.
> 
> Wow, this identical patch was sent as far back as May 31 and is being
> submitted for the 3rd time now :( I hope there will be fewer "bad times"
> like this in the future.


Thanks much Brian.  No big deal.  There's only one other user of this driver
that I'm aware of :(

Thanks also for volunteering to shoulder some of the mtd maintenance duties.
Good job!

Mike




More information about the linux-mtd mailing list