[PATCH v4 05/12] mtd: nand: print out the cell information for nand chip

[Artem Bityutskiy]

On Mon, 2013-09-30 at 15:49 -0700, Brian Norris wrote:
> On Wed, Sep 25, 2013 at 02:58:14PM +0800, Huang Shijie wrote:
> > Print out the cell information for nand chip.
> > 
> > (Since the message is too long, this patch also splits the log
> > with two separate pr_info())
> > 
> > Signed-off-by: Huang Shijie <b32955 at freescale.com>
> > ---
> >  drivers/mtd/nand/nand_base.c |   11 +++++++----
> >  1 files changed, 7 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> > index 94d9084..b94309b 100644
> > --- a/drivers/mtd/nand/nand_base.c
> > +++ b/drivers/mtd/nand/nand_base.c
> > @@ -3460,11 +3460,14 @@ ident_done:
> >  	if (mtd->writesize > 512 && chip->cmdfunc == nand_command)
> >  		chip->cmdfunc = nand_command_lp;
> >  
> > -	pr_info("NAND device: Manufacturer ID: 0x%02x, Chip ID: 0x%02x (%s %s),"
> > -		" %dMiB, page size: %d, OOB size: %d\n",
> > +	pr_info("NAND device: Manufacturer ID: 0x%02x,"
> > +			"Chip ID: 0x%02x (%s %s) \n",
> 
> You're adding excess whitespace before the '\n'. I'll squash this
> myself.

Nowadays' fashion is to never split strings, Huang.

-- 
Best Regards,
Artem Bityutskiy