[PATCH] mtd: m25p80: Add support for Micron N25Q512A memory

[Brian Norris]

On Wed, Oct 2, 2013 at 1:55 PM, Marek Vasut <marex at denx.de> wrote:
> Dear Brian Norris,
>
>> On Wed, Oct 2, 2013 at 1:02 PM, Marek Vasut <marex at denx.de> wrote:
>> > Hi Brian,
>> >
>> >>  + Marek for real!
>> >>
>> >> On Wed, Oct 2, 2013 at 11:51 AM, Brian Norris
>> >>
>> >> <computersforpeace at gmail.com> wrote:
>> >> > + Marek
>> >> >
>> >> > On Wed, Sep 04, 2013 at 10:16:56AM +0530, Priyanka Jain wrote:
>> >> >> Micron N25Q512A is a spi flash memory with following features:
>> >> >> -64MB size, 1.8V, Mulitple I/O, 4KB Sector erase memory.
>> >> >> -Memory is organised as 1024(64KB) main sectors.
>> >> >> -Each sector is divided into 256 pages.
>> >> >> -Register set/Opcodes are similar to other N25Q family products.
>> >> >>
>> >> >> Signed-off-by: Priyanka Jain <Priyanka.Jain at freescale.com>
>> >> >> ---
>> >> >>
>> >> >>  drivers/mtd/devices/m25p80.c |    1 +
>> >> >>  1 files changed, 1 insertions(+), 0 deletions(-)
>> >> >>
>> >> >> diff --git a/drivers/mtd/devices/m25p80.c
>> >> >> b/drivers/mtd/devices/m25p80.c index 26b14f9..94e3b53 100644
>> >> >> --- a/drivers/mtd/devices/m25p80.c
>> >> >> +++ b/drivers/mtd/devices/m25p80.c
>> >> >> @@ -774,6 +774,7 @@ static const struct spi_device_id m25p_ids[] = {
>> >> >>
>> >> >>       { "n25q128a11",  INFO(0x20bb18, 0, 64 * 1024, 256, 0) },
>> >> >>       { "n25q128a13",  INFO(0x20ba18, 0, 64 * 1024, 256, 0) },
>> >> >>       { "n25q256a", INFO(0x20ba19, 0, 64 * 1024, 512, SECT_4K) },
>> >> >>
>> >> >> +     { "n25q512a", INFO(0x20bb20, 0, 64 * 1024, 512, SECT_4K) },
>> >
>> > Why does this n25q256a and n25q512a have exactly the same geometry? I
>> > mean, those chips differ in size, do they not ? ;-)
>> >
>> >> > This device actually has the same ID as Micron's next line
>> >> > (MT25QL512A). They have the same geometry, so maybe that's not a
>> >> > problem.
>>
>> I was referring to Micron n25q512a (which this patch mentions) and
>> Micron's new generation of flash MT25QL512A (not mentioned in the
>> original code or patch). They are different flash and are named
>> differently but have the same ID. Perhaps my usage of the word "line"
>> was confusing.
>
> Yes I know. Still, that n25q512a line being the exact copy of n25q256a doesn't
> seem right.

Sorry, I didn't check the original patch carefully enough, and I
subsequently misunderstood your question. I believe the patch is
incorrect; it should be 512Mbit (64MByte) which makes it 64KB sector x
1024 number of sectors, not 64KB sector x 512 number of sectors. Good
catch.

Priyanka, can you submit and test a corrected patch?

> The new ql512a seems line just a compatible replacement part for older lineup.
> Happens all the time.

Hmm, OK.

Brian