[PATCH] Clarify error on directive in macro arguments (Re: [PATCH] jffs2: fix sparse errors: directive in argument list)
Greg Price
price at MIT.EDU
Sun Nov 17 23:01:00 EST 2013
On Sun, Nov 17, 2013 at 06:15:32PM -0800, Joe Perches wrote:
> On Sun, 2013-11-17 at 21:07 -0500, Greg Price wrote:
> > Perhaps the following tweak to the error message would make this
> > subtlety clearer?
>
> Maybe, but this case isn't a macro. It's a function.
> Dunno if differentiating when it's a macro or a
> function is difficult though.
Yeah, this error message is already only emitted for directives in
macro arguments -- in this case, pr_info. It's in sparse's
preprocessor code; the error arises when a directive is spotted while
parsing a macro's arguments. By the time sparse (or an idealized C
compiler) parses the arguments of a real function, the token stream is
already the output of the preprocessor and any directives are gone.
Cheers,
Greg
More information about the linux-mtd
mailing list