[PATCH] jffs2: fix sparse errors: directive in argument list

Richard Weinberger richard.weinberger at gmail.com
Sun Nov 17 17:53:16 EST 2013


On Sun, Nov 17, 2013 at 11:45 PM, Joe Perches <joe at perches.com> wrote:
> On Sun, 2013-11-17 at 20:34 -0200, Erico Nunes wrote:
>> Do you mean it as an error in the sparse tool?
>
> Yes.  I think it's a defect in how sparse
> treats string concatenation.
>
> That style:
>
>         printk("%s\n",
> #ifdef FOO
>         "foo"
> #endif
> #ifdef BAR
>         "bar"
> #endif
>         "string");
>
> is pretty common in the kernel sources.
>
> The patch itself is otherwise fine, but
> perhaps unnecessary.

I agree with Joe, the patch fixes a non-issue.

-- 
Thanks,
//richard



More information about the linux-mtd mailing list