[PATCH 5/6] jfs: simplify lmNextPage() via list_last_entry_or_null()
Jeff Liu
jeff.liu at oracle.com
Thu Nov 14 23:34:44 EST 2013
From: Jie Liu <jeff.liu at oracle.com>
Simplify the code in lmNextPage via list_last_entry_or_null().
Signed-off-by: Jie Liu <jeff.liu at oracle.com>
---
fs/jfs/jfs_logmgr.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
index 360d27c..7b565d0 100644
--- a/fs/jfs/jfs_logmgr.c
+++ b/fs/jfs/jfs_logmgr.c
@@ -591,10 +591,7 @@ static int lmNextPage(struct jfs_log * log)
* write or queue the full page at the tail of write queue
*/
/* get the tail tblk on commit queue */
- if (list_empty(&log->cqueue))
- tblk = NULL;
- else
- tblk = list_entry(log->cqueue.prev, struct tblock, cqueue);
+ tblk = list_last_entry_or_null(&log->cqueue, struct tblock, cqueue);
/* every tblk who has COMMIT record on the current page,
* and has not been committed, must be on commit queue
--
1.8.3.2
More information about the linux-mtd
mailing list