[PATCH 1/8] mtd: gpmi: do not use the local array to do the DMA transfer

Huang Shijie shijie8 at gmail.com
Thu Nov 14 22:53:52 EST 2013


On Thu, Nov 14, 2013 at 10:46:31AM -0300, Ezequiel Garcia wrote:
> On Thu, Nov 14, 2013 at 02:25:44PM +0800, Huang Shijie wrote:
> 
> ONFI_SUBFEATURE_PARAM_LEN is only 4, so the most natural choice is to
> allocate that in the stack. I think you should add a comment here
> explaining that this buffer needs to be kmallocated for dma purposes.
> 
> Just a nitpick, to avoid people asking why you're doing the allocation
> for just 4 bytes.
i just do not like the warning. 

thanks
Huang Shijie



More information about the linux-mtd mailing list