[PATCH v3] mtd: gpmi: add a new DT property to use the datasheet's minimum required ECC

Brian Norris computersforpeace at gmail.com
Wed Nov 13 15:46:40 EST 2013


On Tue, Nov 12, 2013 at 9:47 AM, Brian Norris
<computersforpeace at gmail.com> wrote:
> + DT maintainers, since they haven't responded
>
> On Mon, Nov 11, 2013 at 9:26 PM, Huang Shijie <b32955 at freescale.com> wrote:
>> 于 2013年11月07日 18:07, Huang Shijie 写道:
>>
>>> In default way, we use the ecc_strength/ecc_step size calculated by
>>> ourselves
>>> and use all the OOB area.
>>>
>>> This patch adds a new property : "fsl,use-minimum-ecc"
>>>
>>> If we enable it, we will firstly try to use the datasheet's minimum
>>> required
>>> ECC provided by the MTD layer (the ecc_strength_ds/ecc_step_ds fields
>>> in the nand_chip{}). So we may have free space in the OOB area by using
>>> the
>>> minimum ECC, and we may support JFFS2 with some SLC NANDs, such as
>>> Micron's
>>> SLC NAND.
>>>
>>> If we fail to use the minimum ECC, we will use the legacy method to
>>> calculate
>>> the ecc_strength and ecc_step size.
>>>
>>> Signed-off-by: Huang Shijie<b32955 at freescale.com>
>>> ---
>>> v1 -->  v2: rebase this patch on the latest l2-mtd.
>>> v2 -->  v3: change the descriptions.
>>> ---
>>>   .../devicetree/bindings/mtd/gpmi-nand.txt          |    8 ++++++++
>>>   drivers/mtd/nand/gpmi-nand/gpmi-nand.c             |    3 +++
>>>   2 files changed, 11 insertions(+), 0 deletions(-)
>>
>> Is this patch ok now? I hope it can be accepted at this merge-window.
>
> The patch is OK to me, but we haven't gotten any DT review. If we
> don't get any response in a few days, I'll take it anyway.

I pushed this to l2-mtd.git/next and will get it into linux-next after
the merge window closes. Let me know if there are further comments.

> I'm not sure about taking it in 3.13 vs. 3.14, as this is
> traditionally a late merge for 3.13.

Queued for 3.14.

Thanks,
Brian



More information about the linux-mtd mailing list