[PATCH RESEND 2/2] mtd: bcm47: convert to module_platform_driver instead of init/exit

Andy Shevchenko andy.shevchenko at gmail.com
Thu May 30 06:30:57 EDT 2013


On Thu, May 30, 2013 at 5:22 AM, Libo Chen <clbchenlibo.chen at huawei.com> wrote:
>
> convert to module_platform_driver instead of init/exit

I give another thought about it. We have to be sure that the flash
device will be online when it's really needed.
module_init initcall is quite far in the boot process. Is it what we want?

> --- a/drivers/mtd/devices/bcm47xxsflash.c
> +++ b/drivers/mtd/devices/bcm47xxsflash.c
> @@ -108,22 +108,4 @@ static struct platform_driver bcma_sflash_driver = {
>   * Init
>   **************************************************/
>
> -static int __init bcm47xxsflash_init(void)
> -{
> -       int err;
> -
> -       err = platform_driver_register(&bcma_sflash_driver);
> -       if (err)
> -               pr_err("Failed to register BCMA serial flash driver: %d\n",
> -                      err);
> -
> -       return err;
> -}
> -
> -static void __exit bcm47xxsflash_exit(void)
> -{
> -       platform_driver_unregister(&bcma_sflash_driver);
> -}
> -
> -module_init(bcm47xxsflash_init);
> -module_exit(bcm47xxsflash_exit);
> +module_platform_driver(bcma_sflash_driver);
> --
> 1.7.1
>
>



--
With Best Regards,
Andy Shevchenko



More information about the linux-mtd mailing list