[PATCH] mtd: mtdchar: Exit write loop when hitting end of OTP memory

Artem Bityutskiy dedekind1 at gmail.com
Wed May 29 09:56:38 EDT 2013


On Wed, 2013-05-29 at 15:19 +0200, Christian Riesch wrote:
> The OTP code for the AMD command set in my recent patchset is modeled 
> after the existing code in drivers/mtd/chips/cfi_cmdset_0001.c. 
> Therefore it has a ...walk() function that walks from chip to chip and 
> tries to write as much data as possible into the OTP memories of these 
> chips. Until the last iteration of this loop it does not know how much 
> OTP memory is available. Therefore, a check for insufficient OTP memory 
> and returning an error before writing any data is not possible.
> 
> Of course I could change my code to obtain the available OTP memory 
> before writing any data. But then the code in cfi_cmdset_0001.c would 
> still suffer from this issue.

Could you please check OneNAND and other drivers which implement OTP and
see whether they check for space availability?

On the first glance, I'd say that 0001 should be amended as well. But if
all OTP writers behave this way, then may be we can document this
clearly at least somewhere in a commentary.

-- 
Best Regards,
Artem Bityutskiy




More information about the linux-mtd mailing list