[PATCH RESEND] mtd: denali: fix error handling for devm_ioremap_nocache()

Xi Wang xi.wang at gmail.com
Fri May 3 00:37:19 EDT 2013


It is incorrect to use `!res' for error handling since `res' must be
non-null.  Use the return value `ptr' instead.

Signed-off-by: Xi Wang <xi.wang at gmail.com>
---
 drivers/mtd/nand/denali_dt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/denali_dt.c b/drivers/mtd/nand/denali_dt.c
index 546f8cb..02988b0 100644
--- a/drivers/mtd/nand/denali_dt.c
+++ b/drivers/mtd/nand/denali_dt.c
@@ -42,7 +42,7 @@ static void __iomem *request_and_map(struct device *dev,
 	}
 
 	ptr = devm_ioremap_nocache(dev, res->start, resource_size(res));
-	if (!res)
+	if (!ptr)
 		dev_err(dev, "ioremap_nocache of %s failed!", res->name);
 
 	return ptr;
-- 
1.8.1.2




More information about the linux-mtd mailing list