Re: [RFC "v2"] mtd: nand: reintroduce NAND_NO_READRDY as NAND_NEED_READRDY

[Alexander Shiyan]

> This (somewhat) reverts commit 1696e6bc2ae83734e64e206ac99766ea19e9a14e.
> 
> In the patch "mtd: nand: kill NAND_NO_READRDY", I overlooked a few
> things.
> 
> The original documentation for NAND_NO_READRDY included "True for all
> large page devices, as they do not support autoincrement." I was
> conflating "not support autoincrement" with the NAND_NO_AUTOINCR option,
> which was in fact doing nothing. So, when I dropped NAND_NO_AUTOINCR, I
> concluded that I then could harmlessly drop NAND_NO_READRDY. But of
> course the fact the NAND_NO_AUTOINCR was doing nothing didn't mean
> NAND_NO_READRDY was doing nothing...
> 
> So, NAND_NO_READRDY is re-introduced as NAND_NEED_READRDY and applied
> only to those few remaining small-page NAND which needed it in the first
> place.
> 
> This is probably a candidate for stable, but there will certainly be
> conflicts, as drivers/mtd/nand/nand_ids.c has changed significantly.
> 
> Compile-tested only; I don't have a setup that requires this.
> 
> Reported-by: Alexander Shiyan <shc_work at mail.ru>
> Signed-off-by: Brian Norris <computersforpeace at gmail.com>
> ---
> 
> This is an attempt at a version 2 of Alexander's RFC patch. I feel like the
> original (per NAND chip type) option makes more sense than per driver (where
> Alexander sets this option only for the diskonchip driver). But it is certainly
> more invasive. And apparently, no one else needs this option (or at least, no
> one complains). Perhaps everyone has just moved beyond small-page NAND?
...

Tested today with 3 DiskOnChip devices which contain following chips:
NAND device: Manufacturer ID: 0x98, Chip ID: 0x75 (Toshiba NAND 32MiB 3,3V 8-bit), 32MiB, page size: 512, OOB size: 16
NAND device: Manufacturer ID: 0xec, Chip ID: 0x75 (Samsung NAND 32MiB 3,3V 8-bit), 32MiB, page size: 512, OOB size: 16
NAND device: Manufacturer ID: 0x98, Chip ID: 0xe6 (Toshiba NAND 8MiB 3,3V 8-bit), 8MiB, page size: 512, OOB size: 16

All OK. Thanks.

---