Re[2]: [PATCH 1/3] mtd: nand_base: Removed unnecessary command masking

Alexander Shiyan shc_work at mail.ru
Tue Mar 5 01:16:39 EST 2013


> On Thu, Feb 28, 2013 at 12:02 AM, Alexander Shiyan <shc_work at mail.ru> wrote:
> > NAND command, passed to cmd_ctrl(), is masked with 0xff. This patch
> > removes this since masking is not necessary and masking is not performed
> > in other places for same call.
> 
> As I commented on the other thread, this is not a sufficient
> explanation. AG-AND (soon to be removed) may use a fake 9-bit command
> which could expect this masking, even though masking is not done
> everywhere. Please document why the command does not need to be
> masked.

I think the best if Artem take this part into his patch.
And what about [3/3] part?

---


More information about the linux-mtd mailing list