[PATCH 6/6] mtd: ofpart: add compatible check for child nodes

Sergei Shtylyov sergei.shtylyov at cogentembedded.com
Thu Jun 13 09:13:43 EDT 2013


Hello.

On 13-06-2013 7:42, Josh Wu wrote:

>>> If the child node has compatible property then it is a driver not
>>> partition.

>>> Signed-off-by: Josh Wu <josh.wu at atmel.com>
>>> ---
>>>   drivers/mtd/ofpart.c |   14 +++++++++++++-
>>>   1 file changed, 13 insertions(+), 1 deletion(-)


>>> diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c
>>> index 553d6d6..61ce1f8 100644
>>> --- a/drivers/mtd/ofpart.c
>>> +++ b/drivers/mtd/ofpart.c
>> [...]
>>> @@ -40,8 +44,13 @@ static int parse_ofpart_partitions(struct mtd_info
>>> *master,
>>>       /* First count the subnodes */
>>>       pp = NULL;
>>>       nr_parts = 0;
>>> -    while ((pp = of_get_next_child(node, pp)))
>>> +    while ((pp = of_get_next_child(node, pp))) {

>>    Assignment in *while*? Is scripts/checkpatch.pl happy about that?

> yes, checkpatch.pl has no complain  ;-)

    It seems checkpatch.pl only complains about *if*. Not very consistent...

WBR, Sergei




More information about the linux-mtd mailing list