[PATCH] mtd: orion_nand: convert printk to dev_*

Emil Goode emilgoode at gmail.com
Sun Jun 9 18:39:20 EDT 2013


Hello Dan,

Thank you for pointing this out, I was going to send a second version
and fix that typo anyway so I will send a patch that applies on top
of Andy's patch and also remove that error message for kzalloc.

Best regards,

Emil

On Mon, Jun 10, 2013 at 01:18:08AM +0300, Dan Carpenter wrote:
> On Mon, Jun 10, 2013 at 12:16:54AM +0300, Andy Shevchenko wrote:
> > It's better to use actual device name as a prefix in error messages.
> > 
> 
> Gar...
> 
> This doesn't apply on top of Emil's patch.  Emil's patch was first
> so it should go in first.  Also Emil's patch was a bugfix so it is
> more important than this printk cleanup patch.
> 
> Really, the kzalloc error messages should just be deleted.  They are
> cargo cult error messages as in "we need an error message because
> we are copy and pasting from other code without thinking."  Kzalloc
> already has far better messages built in.
> 
> Ah well...
> 
> regards,
> dan carpenter



More information about the linux-mtd mailing list