[PATCH] mtd: orion_nand: Improve error handling in orion_nand_probe
Dan Carpenter
dan.carpenter at oracle.com
Sun Jun 9 16:57:47 EDT 2013
On Sun, Jun 09, 2013 at 10:27:03PM +0300, Andy Shevchenko wrote:
> On Sun, Jun 9, 2013 at 10:17 PM, Dan Carpenter <dan.carpenter at oracle.com> wrote:
> > On Sun, Jun 09, 2013 at 08:15:20PM +0300, Andy Shevchenko wrote:
>
> []
>
> >> What about another patch (that I guess should go first) that converts
> >> printk to dev_* or pr_*?
>
> > Huh, what? Those are two totally unrelated things. Emil's patch is
> > a bug fix.
>
> To be precise his patch is bugfix and cleanup at once.
> My proposal is to add a clean up patch.
The printk idea isn't a bad one, it's just totally unrelated to what
the patch is doing. You can't just randomly tell people to do a
bunch of work for no reason. "Good bugfix, but before we apply it
you have to mow my lawn."
regards,
dan carpenter
More information about the linux-mtd
mailing list