[PATCH v2 1/4] mtd: cfi_cmdset_0002: Add support for reading OTP

Artem Bityutskiy dedekind1 at gmail.com
Mon Jun 3 05:40:14 EDT 2013


On Wed, 2013-05-29 at 16:36 +0200, Christian Riesch wrote:
> > But retlen is where you return the amount of bytes you actually
> wrote.
> > The return code is either 0 or a negative error code number. This is
> > what we do in mtd_write() and I'd expect the OTP functions to be
> > consistent.
> 
> Unlike mtd_write, mtd->_get_fact_prot_info (which is a pointer to 
> cfi_amdstd_get_fact_prot_info here) does not have a retlen parameter.
> Do 
> you suggest to change this?

Yes, I would suggest this.

-- 
Best Regards,
Artem Bityutskiy




More information about the linux-mtd mailing list