[RESEND][PATCH] mtd: refactor call to request_module
Rusty Russell
rusty at rustcorp.com.au
Tue Jul 9 23:10:35 EDT 2013
Kees Cook <keescook at chromium.org> writes:
> This reduces the size of the stack frame when calling request_module().
> Performing the sprintf before the call is not needed.
>
> Signed-off-by: Kees Cook <keescook at chromium.org>
Acked-by: Rusty Russell <rusty at rustcorp.com.au>
Thanks,
Rusty.
> ---
> drivers/mtd/chips/gen_probe.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/chips/gen_probe.c b/drivers/mtd/chips/gen_probe.c
> index 74dbb6b..ffb36ba 100644
> --- a/drivers/mtd/chips/gen_probe.c
> +++ b/drivers/mtd/chips/gen_probe.c
> @@ -211,9 +211,7 @@ static inline struct mtd_info *cfi_cmdset_unknown(struct map_info *map,
>
> probe_function = __symbol_get(probename);
> if (!probe_function) {
> - char modname[sizeof("cfi_cmdset_%4.4X")];
> - sprintf(modname, "cfi_cmdset_%4.4X", type);
> - request_module(modname);
> + request_module("cfi_cmdset_%4.4X", type);
> probe_function = __symbol_get(probename);
> }
>
> --
> 1.7.9.5
>
>
> --
> Kees Cook
> Chrome OS Security
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
More information about the linux-mtd
mailing list