[PATCH v4 2/4] ARM: OMAP2+: cleaned-up DT support of various ECC schemes

Gupta, Pekon pekon at ti.com
Mon Jul 8 00:37:36 EDT 2013


> 
> diff --git a/Documentation/devicetree/bindings/mtd/gpmc-nand.txt
> b/Documentation/devicetree/bindings/mtd/gpmc-nand.txt
> index 6a983c1..690070e 100644
> --- a/Documentation/devicetree/bindings/mtd/gpmc-nand.txt
> +++ b/Documentation/devicetree/bindings/mtd/gpmc-nand.txt
> @@ -17,20 +17,42 @@ Required properties:
> 
>  Optional properties:
> 
> - - nand-bus-width: 		Set this numeric value to 16 if the hardware
> -				is wired that way. If not specified, a bus
> -				width of 8 is assumed.
> + - nand-bus-width: 		Determines data-width of the connected
> device
> +				x16 = "16"
> +				x8  = "8" (default)
> 
> - - ti,nand-ecc-opt:		A string setting the ECC layout to use. One of:
> 
> -		"sw"		Software method (default)
> -		"hw"		Hardware method
> -		"hw-romcode"	gpmc hamming mode method & romcode
> layout
> -		"bch4"		4-bit BCH ecc code
> -		"bch8"		8-bit BCH ecc code
> + - ti,nand-ecc-opt:		Determines the ECC scheme used by driver.
> +				It can be any of the following strings:
> +
> +	"hamming_code_sw"		1-bit Hamming ECC
> +					- ECC calculation in software
> +					- Error detection in software
> +
> +	"hamming_code_hw"		1-bit Hamming ECC
> +					- ECC calculation in hardware
> +					- Error detection in software
> +
> +	"hamming_code_hw_romcode"	1-bit Hamming ECC
> +					- ECC calculation in hardware
> +					- Error detection in software
> +					- ECC layout compatible to ROM code
> +
> +	"bch8_hw_code_detection_sw"	8-bit BCH ECC
> +					- ECC calculation in hardware
> +					- Error detection in software
> +					- depends on
> CONFIG_MTD_NAND_ECC_BCH
> +
> +	"bch8_code_hw"             	8-bit BCH ECC
> +					- ECC calculation in hardware
> +					- Error detection in hardware
> +					- depends on
> CONFIG_MTD_NAND_OMAP_BCH
> +					- requires <elm_id> to be specified
> +
> +
> + - elm_id:			Specifies elm device node. This is required to
> +				support some BCH ECC schemes mentioned
> above.
> 
> - - elm_id:	Specifies elm device node. This is required to support BCH
> - 		error correction using ELM module.
> 

[Pekon] Requesting DT maintainers to please review the above 
changes in values for 'nand-ecc-opt' property. And please ACK | NAK it.

with regards, pekon




More information about the linux-mtd mailing list