[PATCH] mtd: physmap_of: Fix map name when "linux, mtd-name" is absent

Pawel Moll pawel.moll at arm.com
Wed Jan 30 06:30:52 EST 2013


On Wed, 2013-01-30 at 11:07 +0000, Florian Fainelli wrote:
> > Commit d68cbdd4fb04d2b756ad53c22f36943167b16340 "mtd: physmap_of:
> > allow to specify the mtd name for retro compatiblity" introduced
> > a "linux,mtd-name" property to override map names, but when
> > this property is absent (so of_property_read_string() returns
> > value != 0) an uninitialized value is used (as mtd_name is not
> > set). This may lead to kernel oopses when the name is
> > derefernced, eg:
> >
> > Unable to handle kernel NULL pointer dereference at virtual address 00000001
> > pgd = 80004000
> > [00000001] *pgd=00000000
> > Internal error: Oops: 5 [#1] SMP ARM
> > Modules linked in:
> > CPU: 3    Not tainted  (3.8.0-rc5+ #644)
> > PC is at strcmp+0x4/0x30
> > LR is at parse_cmdline_partitions+0x54/0x2f8
> >
> > Fixed by initializing the variable to NULL.
> 
> This is the 3rd time such a patch is submitted.
> 
> 1358446932-7238-1-git-send-email-stef.van.os at prodrive.nl
> df9da712b775781366ae23aac28ed20849b4e4d3.1356260943.git.baruch at tkos.co.il
> 
> Fortunately it is now in linux-mtd:
> http://git.infradead.org/linux-mtd.git/commit/7dfe4be351e81656ca1068e5d4ead235c7ba94b1

Great, thanks for letting me know!

Pawel





More information about the linux-mtd mailing list