[PATCH v2] mtd: cfi_cmdset_0002: Support Persistent Protection Bits (PPB) locking

[Stefan Roese]

On 01/15/2013 10:10 AM, Artem Bityutskiy wrote:
> On Thu, 2012-12-13 at 09:29 +0100, Stefan Roese wrote:
>> Currently cfi_cmdset_0002.c does not support PPB locking of sectors. This
>> patch adds support for this locking/unlocking mechanism. It is needed on
>> some platforms, since newer U-Boot versions do support this PPB locking
>> and protect for example their environment sector(s) this way.
> 
> Some "#ifdef CONFIG_OF"s are missing:
> 
> drivers/mtd/chips/cfi_cmdset_0002.c: In function ‘cfi_cmdset_0002’:
> drivers/mtd/chips/cfi_cmdset_0002.c:579:4: error: implicit declaration of function ‘of_property_read_bool’ [-Werror=implicit-function-declaration]

Okay. Will add in next version.

> drivers/mtd/chips/cfi_cmdset_0002.c: In function ‘do_read_secsi_onechip’:
> drivers/mtd/chips/cfi_cmdset_0002.c:1146:16: warning: variable ‘timeo’ set but not used [-Wunused-but-set-variable]
> cc1: some warnings being treated as errors
> make[4]: *** [drivers/mtd/chips/cfi_cmdset_0002.o] Error 1
> 
> Please, check allso the timeo warning.

Hmmm. I didn't touch do_read_secsi_onechip() with this patch. And I'm
not able to reproduce this warning. Are you sure this warning is
introduced by this PPB locking patch?

Thanks,
Stefan