[PATCH v2] davinci_nand: fix modular build with CONFIG_OF=y
Sekhar Nori
nsekhar at ti.com
Fri Jan 4 00:52:26 EST 2013
Hi Sergei,
On 1/3/2013 11:57 PM, Sergei Shtylyov wrote:
> Commit cdeadd712f52b16a9285386d61ee26fd14eb4085 (mtd: nand: davinci: add OF
> support for davinci nand controller) has never been really build tested with
> the driver as a module. When the driver is built-in, the missing semicolon
> after structure initializer is "compensated" by MODULE_DEVICE_TABLE() macro
> being empty and so the initializer using the trailing semicolon on the next
> line; when the driver is built as a module, compilation error ensues, and as
> the 'davinci_all_defconfig' has the NAND driver modular, this error prevents
> DaVinci family kernel from building...
>
> Signed-off-by: Sergei Shtylyov <sshtylyov at ru.mvista.com>
> Cc: stable at vger.kernel.org # 3.7
>
> ---
> The patch is atop of the recent Linus' tree.
> Sekhar, have you build tested at least 3.8-rc1?
v3.8-rc2 builds and boots fine. 'make modules' needs your patch, of
course. For this patch, FWIW:
Acked-by: Sekhar Nori <nsekhar at ti.com>
Thanks,
Sekhar
More information about the linux-mtd
mailing list