[PATCH] mtd: nand: support BENAND (Built-in ECC NAND)

[katsuki.uwatoko at toshiba.co.jp]

Vikram, 

Thank you for comments.

> > +
> > +		/* check BENAND (embedded ECC) */
> > +		if (id_data[0] == NAND_MFR_TOSHIBA &&
> > +		    (id_data[4] & 1 << 7))
> 
> Can the (1 << 7) be made as some macro, with an understandable name?

I will fix this.

> > +			pr_warn("CONFIG_MTD_BENAND not enabled\n");
> > +			BUG();
> 
> Should you really BUG here?

I think so, because this does not happen. 
If CONFIG_MTD_NAND_BENAND is not enabled, nobody sets NAND_ECC_BENAND.  

> If IS_ENABLED is used, the above would go off.

I will rewrite this driver by using "IS_ENABLED" and resend it.

Thanks again,
-- 
UWATOKO Katsuki