[PATCH 1/2] mtd: physmap_of: Convert device allocation to managed devm_kzalloc()

Ezequiel Garcia elezegarcia at gmail.com
Mon Feb 4 07:36:33 EST 2013


Artem,

On Fri, Jan 25, 2013 at 11:50 AM, Ezequiel Garcia
<ezequiel.garcia at free-electrons.com> wrote:
> Tested by compilation only.
>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia at free-electrons.com>
> ---
>  drivers/mtd/maps/physmap_of.c |    8 +++-----
>  1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mtd/maps/physmap_of.c b/drivers/mtd/maps/physmap_of.c
> index 67cc73c..c69e5c4 100644
> --- a/drivers/mtd/maps/physmap_of.c
> +++ b/drivers/mtd/maps/physmap_of.c
> @@ -68,9 +68,6 @@ static int of_flash_remove(struct platform_device *dev)
>                         kfree(info->list[i].res);
>                 }
>         }
> -
> -       kfree(info);
> -
>         return 0;
>  }
>
> @@ -199,8 +196,9 @@ static int of_flash_probe(struct platform_device *dev)
>         map_indirect = of_property_read_bool(dp, "no-unaligned-direct-access");
>
>         err = -ENOMEM;
> -       info = kzalloc(sizeof(struct of_flash) +
> -                      sizeof(struct of_flash_list) * count, GFP_KERNEL);
> +       info = devm_kzalloc(&dev->dev,
> +                           sizeof(struct of_flash) +
> +                           sizeof(struct of_flash_list) * count, GFP_KERNEL);
>         if (!info)
>                 goto err_flash_remove;
>
> --
> 1.7.8.6
>

I've just tested this physmap series.
Can you pick only this one?

The other two depend on the devm_ioremap_resource() patch,
so I'll re-submit them when that patch hits your tree.

Thanks,

-- 
    Ezequiel



More information about the linux-mtd mailing list