[PATCH V6 18/30] fs: add read_iter and write_iter to several file systems

Artem Bityutskiy dedekind1 at gmail.com
Fri Feb 1 02:51:09 EST 2013


On Tue, 2013-01-29 at 10:23 -0600, Dave Kleikamp wrote:
> -       .aio_read = generic_file_aio_read,
> -       .aio_write = generic_file_aio_write,
> +       .read_iter = generic_file_read_iter,
> +       .write_iter = generic_file_write_iter, 

The new names a lot less self-documenting than the old ones - I read
them as "read iteration", because "iter" is often used for "iteration",
and this gives me no clue that they are related to AIO...

I apologize if this was already discussed, but why did you choose
"iter"?

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20130201/a57645f9/attachment.sig>


More information about the linux-mtd mailing list