[PATCH] mtd: tests: oobtest: fix test failures for oobsize which are not multiples of 4

Brian Norris computersforpeace at gmail.com
Thu Dec 19 20:50:31 EST 2013


+ Akinobu

On Thu, Dec 19, 2013 at 11:20:20AM +0000, Pekon Gupta wrote:
> >From: 'George Cherian <george.cherian at ti.com>'
> >Date: Monday, October 28, 2013 1:37 PM
> >Subject: [PATCH] mtd: tests: oobtest: fix test failures for oobsize which are not multiples of 4
> >
> >If oobsize is not multiple of 4 then the generated data to write to flash
> >and data generated to verify are not same. This imapcts test cases 2,3 and 5.
> >If mtd->ecclayout->oobavail is not a multiple of 4 then while generating psuedo
> >random numbers to write to flash prandom_bytes_state () generates the extra
> >random bytes which wont be done if we do for the whole length. So check
> >for mtd->ecclayout->oobavail if its multiple of 4 then generate for full len
> >(mtd->ecclayout->oobavail * pgcnt)
> >else generate prandom of mtd->ecclayout->oobavail bytes pgcnt times.
> >
> >Signed-off-by: George Cherian <george.cherian at ti.com>
...
> 
> I think this patch never saw the linux-mtd list. so just fwding ..

I cannot apply or review this patch as-is. Please resend it as a
standard inline patch.

That being said, from a first glance, I doubt this patch is correct.
I'll take a look if I get a proper patch.

Brian



More information about the linux-mtd mailing list