[PATCH RESEND 0/3] pxa3xx-nand: Support 2 KiB page size devices

Brian Norris computersforpeace at gmail.com
Thu Dec 19 02:24:27 EST 2013


On Wed, Dec 18, 2013 at 06:44:07PM -0300, Ezequiel Garcia wrote:
> PATCH 1 fixes a problem that can be triggered by writing a blank
> page (0xff). The bug itself was found by Arnaud Ebalard while testing 2048B
> page size support on the Armada 370/XP variant, yet the bug can be reproduced
> on the driver's PXA variant.
> 
> The other two patches enable the support for 2048B pages on the Armada 370/XP
> variant.
> 
> PATCH 2 reduces the I/O overhead on flash devices that won't need the extended
> command semantics, by changing the way the cmdfunc() variants are used. The
> decision of which cmdfunc() should be used is now made based on the page size
> and not on thec ontroller variant.
> 
> PATCH 3, consolidates the ECC initialization -mostly to avoid code duplication-
> since the A370/XP variant can also support smaller pages, with no-BCH
> requirements.
> 
> I think the driver looks slightly cleaner after this work, but feel free to
> provide any feedback or advise differently.

These patches look good to me. Pushed to l2-mtd.git. Thanks!

Brian



More information about the linux-mtd mailing list