[PATCH v3 0/7] mtd: spi-nor: add a new framework for SPI NOR
Gupta, Pekon
pekon at ti.com
Tue Dec 17 00:45:38 EST 2013
>From: Huang Shijie [mailto:b32955 at freescale.com]
>>From: Pekon Gupta [mailto:pekon at ti.com]
[...]
>> (1) Add sign-offs of main authors of m25p80, so that original contributors
>> still remains in path of submission [1].
>Do you mean add the sign-offs in end of the patch 3's commit message?:
> Signed-off-by: Mike Lavender <mike at steroidmicros.com>
>
I think Mike's email ID is no-more valid. So you can either find out his
current email-Id from other sources. OR
add David's or someone else's ID which has equivalent number of
contributions in m25p80.c (that you can figure out from either commit
logs or git blame).
>>
>> (2) Also, please remove following from spi-nor.c
>> However, you can keep this in fsl-quadspi.c.
>> +MODULE_AUTHOR("Freescale Semiconductor Inc.");
>> I'm sure this was _not_ present in original m25p80.c
>> (m25p80.c was started as ST's driver as per MODULE_DESCRIPTION)
>okay.
>
Thanks much.
You can put your name instead, I don't mind that bcoz you have worked
to get this framework assembled by joining different pieces.
However, please use a email-id which is valid for long-term (preferably
your personal ID), so that even if your association with your company ends,
still there is some way to track you and keep you in loop of future patches
for this framework.
>>
>> (3) +MODULE_LICENSE("GPL");
>> Also, I assume the license version should be "GPLv2" ?
>
>yes. it should be v2.
>
with regards, pekon
More information about the linux-mtd
mailing list