[PATCH] mtd: nand: pxa3xx: Use info->use_dma to release DMA resources

[Brian Norris]

Sorry this one fell through a bit.

On Wed, Nov 27, 2013 at 08:34:06AM -0300, Ezequiel Garcia wrote:
> On Tue, Nov 26, 2013 at 11:58:19PM -0800, Brian Norris wrote:
> > For my reference, have you actually seen this bug in practice? I'm not
> > sure how well this fits in the -stable rules, if it hasn't been observed
> > and tested appropriately.
> 
> Yes, I've seen this bug in practice, or otherwise wouldn't notice such small
> typo :-) The bug was triggered in PXA platforms, when the device cannot
> be identified (nand_scan fails).
> 
> It's a very rare condition, but it's a real bug. Is that enough for -stable?

Yes, this qualifies just fine. I'm not quite sure how far back this can
go on stable, though, as we have a lot of churn in pxa3xx_nand.c. It
looks like the bug is long-standing, but we may need to port it for
older releases. Let me know what you want to do here.

BTW, am I reading something wrong or is pxa3xx_nand.c broken for
multi-CS systems? It seems like each chip's pxa3xx_nand_scan() will take
turns overwriting info->buf_size and info->data_buff, leaking memory in
the process. I guess the driver's designed to only use one chip at a
time?

Brian