[PATCH v3 01/10] mtd: nand: rename the cellinfo to bits_per_cell
Vikram Narayanan
vikram186 at gmail.com
Tue Aug 27 13:10:47 EDT 2013
On 26/Aug/2013 3:06 PM, Huang Shijie wrote:
> diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
> index 2ed2bb3..645721e 100644
> --- a/drivers/mtd/nand/denali.c
> +++ b/drivers/mtd/nand/denali.c
> @@ -1520,7 +1520,7 @@ int denali_init(struct denali_nand_info *denali)
> * so just let controller do 15bit ECC for MLC and 8bit ECC for
> * SLC if possible.
> * */
> - if (denali->nand.cellinfo & NAND_CI_CELLTYPE_MSK &&
> + if (!nand_is_slc(&denali->nand) &&
> (denali->mtd.oobsize > (denali->bbtskipbytes +
> ECC_15BITS * (denali->mtd.writesize /
> ECC_SECTOR_SIZE)))) {
Was just skimming thro this patchset.
Isn't the above change logically conflicting with what this patch is
supposed to address? Please move this to a different patch.
More information about the linux-mtd
mailing list