[PATCH -next] mtd: atmel_nand: fix error return code in atmel_nand_probe()

Josh Wu josh.wu at atmel.com
Thu Aug 22 23:54:14 EDT 2013


Hi, Wei Yongjun

On 8/23/2013 10:50 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>

Thank you for catch this and
Acked-by: Josh Wu <josh.wu at atmel.com>

> ---
>   drivers/mtd/nand/atmel_nand.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index 65b302c..093bcf8 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -2047,6 +2047,7 @@ static int __init atmel_nand_probe(struct platform_device *pdev)
>   		irq = platform_get_irq(pdev, 0);
>   		if (irq < 0) {
>   			dev_err(host->dev, "Cannot get HSMC irq!\n");
> +			res = irq;
>   			goto err_nand_ioremap;
>   		}
>   
>

Best Regards,
Josh Wu



More information about the linux-mtd mailing list