[RESEND][PATCH] mtd: chips: Add support for PMC SPI Flash chips in m25p80.c

Marek Vasut marex at denx.de
Wed Aug 21 04:07:17 EDT 2013


Dear Brian Norris,

> On Wed, Aug 21, 2013 at 09:41:38AM +0200, Marek Vasut wrote:
> > Dear Brian Norris,
> > 
> > > + Marek, since he's been reviewing (with dismay?) the increase in macro
> > > flags in this driver. If there are any objections, I can amend/drop the
> > > patch.
> > 
> > Hmmm ... this SECT_4K_PMC seems too combined to me. Why don't we use the
> > SECT_4K flag and another flag to indicate it's a PMC part? Even better,
> > I recall you can
> 
> Separating manufacturer from SECT_4K sounds good, but it really doesn't
> buy us much. See my next comments.

I see, that's really bad news. Thanks for the explanation!

I guess there really is nothing much we can do about such parts. But then if we 
take device tree probe into consideration, we might actually want to match the 
part name to discern the PMS device. Or am I talking complete nonsense?

Best regards,
Marek Vasut



More information about the linux-mtd mailing list