[PATCH 01/10] mtd: set the cell information for ONFI nand

Brian Norris computersforpeace at gmail.com
Mon Aug 12 22:59:33 EDT 2013


On Mon, Aug 12, 2013 at 7:32 PM, Huang Shijie <b32955 at freescale.com> wrote:
> 于 2013年08月13日 08:49, Brian Norris 写道:
>> On Mon, Aug 12, 2013 at 07:22:38AM +0000, Gupta, Pekon wrote:
>> for chips listed by full-ID, add an appropriate flag/field; and for ONFI
>> chips, just use p->bits_per_cell.
>
> we do not need to worry about the full-id case, we can get the correct cell
> info from the id[2] for all the 4 toshiba nand.

I see. I forgot that you assign nand_chip.cellinfo in
find_full_id_nand(). It still seems like a bad design decision to base
the implementation of the full-ID table on the fact that it currently
only holds your 4 Toshiba entries, but I suppose it can be improved
if/when additions are needed that don't support the same CELLINFO
layout.

Brian



More information about the linux-mtd mailing list