[PATCH 09/10] mtd: add more information for the MTD_NANDFLASH case
Brian Norris
computersforpeace at gmail.com
Mon Aug 12 21:07:50 EDT 2013
On Mon, Aug 12, 2013 at 01:42:52PM +0800, Huang Shijie wrote:
> In mtd_type_show(), the MTD_NANDFLASH case shows "nand".
> In actually, the printed information is not accurate enough.
> The MTD_NANDFLASH stands for SLC nand now.
>
> This patch adds the SLC information for the MTD_NANDFLASH case.
>
> Signed-off-by: Huang Shijie <b32955 at freescale.com>
> ---
> drivers/mtd/mtdcore.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> index c7cee29..78b8f2e 100644
> --- a/drivers/mtd/mtdcore.c
> +++ b/drivers/mtd/mtdcore.c
> @@ -149,7 +149,7 @@ static ssize_t mtd_type_show(struct device *dev,
> type = "nor";
> break;
> case MTD_NANDFLASH:
> - type = "nand";
> + type = "SLC nand";
Nak. This is clearly an ABI change, doesn't follow the existing naming
convention, and isn't even necessary (just differentiating the
"mlc-nand" case in the prior patch is sufficient).
> break;
> case MTD_DATAFLASH:
> type = "dataflash";
Brian
More information about the linux-mtd
mailing list