[PATCH 1/1] mtd: mtdoops: fix for a potential memory leak in mtdoops_notify_remove

Nilanjan Roychowdhury nilanjan.roychowdhury at gmail.com
Sun Aug 11 16:11:48 EDT 2013


we are allocating cxt->oops_page_used using vmalloc in mtdoops_notify_add for
every mtd_info addition but not freeing it in mtdoops_notify_remove

Signed-off-by: Nilanjan Roychowdhury <nilanjan.roychowdhury at gmail.com>
---
 drivers/mtd/mtdoops.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/mtdoops.c b/drivers/mtd/mtdoops.c
index 97bb8f6..02f49aa 100644
--- a/drivers/mtd/mtdoops.c
+++ b/drivers/mtd/mtdoops.c
@@ -386,6 +386,7 @@ static void mtdoops_notify_remove(struct mtd_info *mtd)
 	cxt->mtd = NULL;
 	flush_work(&cxt->work_erase);
 	flush_work(&cxt->work_write);
+	vfree(cxt->oops_page_used);
 }
 
 
-- 
1.7.9.5




More information about the linux-mtd mailing list