[PATCH -next v2 00/10] mtd: tests: reduce duplication among mtd tests modules
Akinobu Mita
akinobu.mita at gmail.com
Wed Aug 7 10:11:07 EDT 2013
2013/8/6 Artem Bityutskiy <dedekind1 at gmail.com>:
> On Sat, 2013-08-03 at 18:52 +0900, Akinobu Mita wrote:
>> This patch set reduces code duplication among mtd/tests modules by
>> moving common helper functions into mtd_test.c.
>>
>
> You could make this nicer by incorporating the error messages to the
> common handlers, and removing them from tests - they are almost the same
> everywhere.
Sounds good. Especially incorporating the error messages to mtdtest_read()
and mtdtest_write() enables to convert some of remaining usages of
mtd_read() and mtd_write in the test modules.
> But this is anyway a good clean-up, so pushed to l2-mtd.git, thanks!
Thanks.
More information about the linux-mtd
mailing list